Opened on 01/08/2016 at 04:43:24 PM
Closed on 01/11/2016 at 11:31:56 AM
Last modified on 01/18/2016 at 01:42:10 AM
#3494 closed change (fixed)
Update buildtools dependency for adblockplus to revision 4d73b9c76e34
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | #3486 | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
This will import the fix for #3490 meaning that all multiprocess compatibility shims will be disabled. With #3486 fixed this should no longer have an impact on our code.
What to change
In addition to updating the dependency we can remove Utils.getPropertyWithoutCompatShims() and all its callers.
What to test
Unfortunately, this change affects pretty much all extension functionality once again, especially Blockable items and Issue reporter.
Attachments (0)
Change History (3)
comment:1 Changed on 01/08/2016 at 04:52:29 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/11/2016 at 11:31:56 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/18/2016 at 01:42:10 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Blockable items, issue reporter and other major features else seem to be behaving correctly.
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64
Note: See
TracTickets for help on using
tickets.
Done: https://hg.adblockplus.org/adblockplus/rev/7b3475848d7c