Opened on 01/19/2016 at 10:28:02 AM
Closed on 08/06/2018 at 05:47:47 PM
#3535 closed defect (rejected)
All JS links on "Adblock Plus has been installed" page stop function if click Contributor Credits link and then click Back browser button
Reported by: | passbrains | Assignee: | |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | greiner | Blocked By: | |
Blocking: | Platform: | Safari | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by greiner)
Adapted from https://platform.passbrains.com/dashboard/view-ticket.php?ticket_no=ASA-61
Environment
Mac + OS X 10.7 + Safari + English
ABP version 1.8.12.1423
How to reproduce
- Install ABP Safari extension
- When "Adblock Plus has been installed" page opens, do not click any other buttons apart from the 'Contributor Credits' link.
- When Contributor Credits page opens click back browser button
- When "Adblock Plus has been installed" page opens click Facebook, Twitter or Google + button in Tell your friends section
Observed behaviour
All JS links on "Adblock Plus has been installed" page stop functioning if click Contributor Credits link and then click Back browser button.
Following functionality stop function with this scenario:
- disable link
- Facebook, Twitter, Google + buttons in Tell your friends section
- All toggles in Adblock Plus can do more than block ads section
Expected behaviour
All JS functionality should continue function after navigate to Contributor Credits page and then back to "Adblock Plus has been installed" page.
Background
It seems that the page is not being reloaded properly (e.g. "DOMContentLoaded" event does not get fired) when navigating back to it via the back button. There are a couple of reports of people encountering the same issue (e.g. jQuery) blaming it on the BFCache.
Since the suggested "pageshow" event is equivalent to the "load" event, it's getting fired later than the "DOMContentLoaded" event so we should use both to ensure that the page is being initialized as early as possible.
What to change
Add a listener for the "pageshow" event to initialize the page in case "DOMContentLoaded" was not fired.
Attachments (2)
Change History (9)
Changed on 01/19/2016 at 10:28:11 AM by passbrains
Changed on 01/19/2016 at 10:28:18 AM by passbrains
comment:1 Changed on 01/19/2016 at 10:28:22 AM by passbrains
comment:3 Changed on 01/19/2016 at 11:02:45 AM by scheer
I reproduced this, but I found that it only occurs if the user does not select one of the buttons as mentioned above before selecting the Contributor Credits page.
Reproduced on OS X 10.10.3 Safari 8.0.6 ABP 1.10.
comment:5 Changed on 01/19/2016 at 04:25:47 PM by greiner
- Cc greiner added
- Component changed from Unknown to User-Interface
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:6 Changed on 09/13/2017 at 04:38:37 PM by sebastian
- Priority changed from P3 to P4
comment:7 Changed on 08/06/2018 at 05:47:47 PM by greiner
- Resolution set to rejected
- Status changed from new to closed
Closing this ticket because we're going to remove this link with the next iteration of the first-run page and Apple is ending support for Safari extensions in favor of content blocking apps.
1 - 29 Jun 2015 11:11:37 posted by Timo Scherf
Reproduced as described with build #1458