Opened on 01/19/2016 at 05:03:26 PM

Closed on 02/12/2016 at 02:50:44 PM

Last modified on 02/24/2016 at 11:40:25 AM

#3541 closed defect (fixed)

Size of DOM Inspector dialogs is wrong first time they are opened

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29336300/

Description

Environment

Adblock Plus 2.7.1 (started with Adblock Plus 2.7 according to user report), Firefox 43, Mac OS X 10.11

Also reproducible in Firefox 46.0a1 nightly with multi-process switched off (DOM Inspector doesn't support E10S).

How to reproduce

  1. Install DOM Inspector 2.0.16: https://addons.mozilla.org/addon/dom-inspector-6622/
  2. On any web page go to menu Tools / Web Developer / DOM Inspector (alternatively you can customize your toolbar and drag the Web Developer menu into it).
  3. Press Cmd/Ctrl+F to open the Find Nodes dialog, dismiss it.
  4. Select an element and double-click an attribute in the right pane to edit it.

Observed behaviour

The dialogs open with buttons only, the content is missing. Second time they are opened correctly however.

Expected behaviour

The dialogs open correctly

Attachments (1)

testpolicy-1.0.xpi (2.1 KB) - added by trev on 02/11/2016 at 03:22:44 PM.
Minimal extension reproducing the issue

Download all attachments as: .zip

Change History (8)

Changed on 02/11/2016 at 03:22:44 PM by trev

Minimal extension reproducing the issue

comment:1 Changed on 02/11/2016 at 03:24:26 PM by trev

I added a minimal extension to reproduce this issue without Adblock Plus. Turns out accessing document.documentElement from nsIContentPolicy.shouldLoad is sufficient to trigger this issue (content policy is called only once per session to check chrome://inspector/skin/inspector.css stylesheet).

comment:2 Changed on 02/11/2016 at 04:53:55 PM by trev

  • Resolution set to invalid
  • Status changed from new to closed

This appears to be the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1127744 - a platform issue, up to Mozilla to figure out what's going on here.

comment:3 Changed on 02/12/2016 at 02:12:25 PM by trev

  • Priority changed from P3 to P1
  • Resolution invalid deleted
  • Status changed from closed to reopened

I realized that there is a simple work-around for this issue, reopening.

comment:4 Changed on 02/12/2016 at 02:12:35 PM by trev

  • Owner set to trev

comment:5 Changed on 02/12/2016 at 02:12:46 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:6 Changed on 02/12/2016 at 02:50:44 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 02/24/2016 at 11:40:25 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Could not reproduce the issue demonstrated by the attachment.

ABP 2.7.2
Firefox 47.0a1 (Nightly) / OS X 10.11.3 x64

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.