Opened on 01/22/2016 at 12:43:09 PM

Closed on 01/22/2016 at 03:04:03 PM

Last modified on 11/08/2016 at 01:00:23 AM

#3562 closed change (fixed)

Use 'ToWstring()' to convert BSTR values

Reported by: oleksandr Assignee:
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Rraceanu Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29333350/

Description

Background

We currently have a lot of calls to SysStringLen all over the code. It would be best to minimize the number of such calls.

What to change

Use 'ToWstring()' to convert BSTR values from interfaces.

Attachments (0)

Change History (3)

comment:1 Changed on 01/22/2016 at 03:04:03 PM by eric@adblockplus.org

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed on 03/01/2016 at 02:25:38 PM by philll

Could you please leave hints for testers?

comment:3 Changed on 11/08/2016 at 01:00:23 AM by rraceanu

  • Tester changed from Unknown to Rraceanu

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.