Opened on 01/26/2016 at 01:48:29 PM
Closed on 11/10/2017 at 11:15:18 AM
#3582 closed defect (rejected)
Blockable items context menu text truncated for long filters
Reported by: | greiner | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Adblock-Plus-for-Firefox | Keywords: | |
Cc: | Shikitita, lisabielik | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Environment
Ubuntu 14.04
Firefox 43.0.4
Adblock Plus 2.7.1.4131 (with German locale)
How to reproduce
- Go to http://www.caranddriver.com/photo-gallery/2017-ford-focus-rs-official-photos-and-info-news
- Open blockable items list
- Right-click on filter that starts with 000webhost.com,…
- Observe context menu entry for disabling the filter
Expected behavior
Context menu entry text says "Filter 000webhost.com,1380thebiz.com,1520thebiz.com,1520wbzw.com,760kgu.bi..."
Observed behavior
Context menu entry text says "Filter deaktivieren"
Background
Unlike in English where the verb is at the beginning (i.e. "Disable filter <filter>"), in German it is at the end (i.e. "Filter <filter> deaktivieren") which means that the message the text is supposed to convey is not getting across.
While we might be able to only truncate the filter rather than the entire phrase, it's probably best to omit it from the text. Note that we also say "Copy filter" instead of "Copy filter <filter>" or "Edit filter in effect..." instead of "Edit filter <filter>...". For consistency we could also change the latter.
What to change
In sidebar.dtd:
- Change text "Disable filter ?1?" to "Disable filter"
- Change text "Re-enable filter ?1?" to "Re-enable filter"
- Change text "Edit filter in effect..." to "Edit filter..."
Attachments (0)
Change History (1)
comment:1 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.