Opened on 02/02/2016 at 01:01:00 PM
Closed on 04/20/2016 at 06:37:55 AM
#3613 closed change (rejected)
Include buildtools directly into libadblockplus
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | Blocked By: | #2594, #3618 | |
| Blocking: | #2596 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In order to make #2596 we need to make libadblockplus directly dependent on buildtools because there won't be buildtools in adblockpluscore.
What to change
Change dependencies and the stuff related to convert_js.
Attachments (0)
Change History (4)
comment:1 Changed on 02/02/2016 at 01:07:44 PM by sergz
- Blocked By 2594 added
comment:2 Changed on 02/03/2016 at 09:50:22 AM by fhd
Turns out we do actually need buildtools in adblockpluscore, see #3618.
comment:3 Changed on 02/03/2016 at 11:53:51 AM by sergz
- Blocked By 3618 added
Add #3618 as blocked by because it can invalidate the current issue.
comment:4 Changed on 04/20/2016 at 06:37:55 AM by sergz
- Resolution set to rejected
- Status changed from new to closed
adblockpluscore contains buildtools, so we don't need to directly include buildtools in libadblockplus.
Note: See
TracTickets for help on using
tickets.
Add blocked by #2594 because firstly we need to know the exact location of jshydra which seems still will be in adblockpluscore (that's actually logical).