Opened on 02/03/2016 at 10:24:16 AM
Closed on 02/03/2016 at 05:41:25 PM
Last modified on 03/08/2016 at 07:30:10 AM
#3620 closed defect (fixed)
"Block element" doesn't consider $genericblock when generating filters
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
How to reproduce
- Add filter @@||google.com^$genericblock
- Go to https://google.com/
- Click ABP toolbar icon
- Choose "Block element"
- Click on the Google logo
- Add the suggested filters
- Reload the page
Observed behaviour
Following filters are suggested (and added):
||google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png ||google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png
After reloading the page, the logo however keeps showing. That is because due to the $genericblock exception rule added earlier, blocking filters without $domain option are ignored.
Expected behaviour
When a $genericblock exception rule is in effect, the "Block element" dialog should suggest only domain specific filters, so that the element actually gets blocked. For the Google logo this would be following filters:
||google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png$domain=google.com ||google.com/images/branding/googlelogo/1x/googlelogo_color_272x92dp.png$domain=google.com
Attachments (0)
Change History (5)
comment:1 Changed on 02/03/2016 at 10:26:01 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 02/03/2016 at 05:41:25 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 02/03/2016 at 05:45:00 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
comment:4 Changed on 02/06/2016 at 01:07:41 PM by sebastian
- Summary changed from "Block element" doesn't consider $genericblock to "Block element" doesn't consider $genericblock when generating filters
comment:5 Changed on 03/03/2016 at 11:00:31 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Behaviour now matches what is described in Expected behaviour (domain is suggested at the end of the filter).
ABP 1.10.2.1558
Chrome 35 / 47 / Windows 7 x86
Chrome 48 / Ubuntu 14.04 x64
Opera 25 / 35 / Windows 7 x86
Opera 35 / Ubuntu 14.04 x64
Safari 6 (OS X 10.8) / Safari 8 (OS X 10.10) / Safari 9 (OS X 10.11)
https://hg.adblockplus.org/adblockpluschrome/rev/7949ccb31087