Opened on 02/03/2016 at 03:37:05 PM

Closed on 02/25/2016 at 06:31:47 AM

#3626 closed defect (fixed)

Ghost mode tab's closing cross button is too close to ghost control buttons

Reported by: michal.kuric Assignee:
Priority: P1 Milestone: Adblock-Browser-for-iOS-1.3.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario, scheer Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: no Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description

Environment

iOS (all versions)
iPhone (all versions)
ABB 1.3.0-qa, (core 1.3.6-qa) (Build 801)
no filters enabled (doesn't affect)

How to reproduce

  1. Open ABB
  2. Select Ghost mode via tab icon in a lower right corner
  3. Open as many new tabs they will fill one page of listing
  4. Scroll down to the last tab

Observed behaviour

Closing button "x" is so close to the ghost mode control buttons that it's uncomfortable to close it.

Expected behaviour

Closing button "x" should be place at more UX friendly place.

Attachments (2)

Screen Shot 2016-02-03 at 4.15.33 PM.png (25.1 KB) - added by michal.kuric on 02/03/2016 at 03:37:22 PM.
bug screenshot
screen_shot_2016-02-03_at_17.22.09_480.png (29.8 KB) - added by jand on 02/18/2016 at 05:03:01 PM.

Download all attachments as: .zip

Change History (8)

Changed on 02/03/2016 at 03:37:22 PM by michal.kuric

bug screenshot

comment:1 Changed on 02/08/2016 at 09:37:51 AM by jand

  • Priority changed from Unknown to P1
  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed on 02/09/2016 at 04:25:18 PM by mario

  • Milestone set to Adblock-Browser-for-iOS-next

Batch modify: added Adblock-Browser-for-iOS-next milestone.

comment:3 Changed on 02/18/2016 at 01:20:51 PM by scheer

  • Cc scheer added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Would it be possible to have some information on the changed design and intended new behaviour? As in, how should the Closing button now react in said situation?

Changed on 02/18/2016 at 05:03:01 PM by jand

comment:4 Changed on 02/18/2016 at 05:09:10 PM by jand

Original tab view with several open tabs with inaccessible close button of the last tab:
https://issues.adblockplus.org/raw-attachment/ticket/3626/Screen%20Shot%202016-02-03%20at%204.15.33%20PM.png

The solution was to allow to move the last tab above add tab banner:
https://issues.adblockplus.org/raw-attachment/ticket/3626/screen_shot_2016-02-03_at_17.22.09_480.png

comment:5 Changed on 02/19/2016 at 09:42:08 AM by mario

  • Cc salsita removed

comment:6 Changed on 02/25/2016 at 06:31:47 AM by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Tester changed from Unknown to Scheer
  • Verified working set
  • The user is now able to slide the bottom most tab in Ghostery mode above the '+' button so that the user is able to delete the tab.

ABB 1.3.0-qa (824)
iPhone 6 Plus - iOS 9.2.1

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.