Opened on 02/06/2016 at 10:31:08 AM
Closed on 03/21/2016 at 12:39:46 PM
#3635 closed defect (fixed)
ensure_dependencies.py doesn't work when neither a .git nor a .hg directory is present
| Reported by: | fhd | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | goodfirstbug |
| Cc: | trev, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by fhd)
Environment
buildtools revision ff4ea4c5f0a1.
How to reproduce
- Create a shallow clone of the buildtools repository: hg archive -R buildtools buildtools-shallow.
- Run ensure_dependencies.py in the buildtools-shallow directory.
Observed behaviour
ensure_dependencies.py exits with the following error:
Traceback (most recent call last):
File "./ensure_dependencies.py", line 371, in <module>
resolve_deps(repo)
File "./ensure_dependencies.py", line 310, in resolve_deps
source, rev = merge_seqs(sources.get("*"), sources.get(vcs))
UnboundLocalError: local variable 'vcs' referenced before assignment
Expected behaviour
The dependencies should be checked out.
Attachments (0)
Change History (6)
comment:1 Changed on 02/06/2016 at 10:35:02 AM by sebastian
- Blocking 1299 added
- Keywords goodfirstbug added
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 02/06/2016 at 10:36:38 AM by fhd
- Description modified (diff)
- Summary changed from ensure_dependencies should default to Mercurial when neither a .hg or .git directory is present to ensure_dependencies.py doesn't work when neither a .git nor a .hg directory is present
- Type changed from change to defect
Last edited on 02/06/2016 at 10:36:49 AM
by fhd
comment:3 Changed on 02/09/2016 at 11:30:37 AM by sebastian
- Blocking 1299 removed
- Priority changed from P2 to P4
comment:4 Changed on 03/18/2016 at 01:48:31 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 03/21/2016 at 12:37:52 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/buildtools/rev/5b11ede67929
comment:6 Changed on 03/21/2016 at 12:39:46 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I thought this makes more sense as a defect. As far as I'm concerned, defaulting to Mercurial is sufficient to fix this. But we can also think about solutions that work if a repository only has Git dependencies specified (a use case we currently don't have, however).