Opened on 02/10/2016 at 11:33:24 AM
Closed on 03/10/2016 at 06:36:00 AM
#3644 closed defect (fixed)
Favicon displayed in empty tabs
| Reported by: | mario | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-1.3.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | salsita |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Environment
iPhone 6
iOS 9.2
ABB 1.3.0-QA
How to reproduce
- Open ABB
- Open a new (empty) tab
- Please notice that there is no favicon displayed in the tabs menu as shown in this screenshot
- Navigate to adblockplus.org
- Please notice that now there is a favicon displayed in the tabs menu as shown in this screenshot
- Navigate back to the dashboard using browser back (or swipe gestures)
Observed behaviour
The favicon of the previously visited site is still displayed for the currently empty tab in the tabs menu as shown in this screenshot.
Expected behaviour
No favicon should be displayed for empty tabs in the tabs menu as shown in this screenshot.
Attachments (3)
Change History (15)
Changed on 02/10/2016 at 11:33:38 AM by mario
Changed on 02/10/2016 at 11:33:44 AM by mario
Changed on 02/10/2016 at 11:33:50 AM by mario
comment:2 Changed on 02/16/2016 at 04:27:42 PM by mario
- Keywords salsita added
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 02/18/2016 at 04:48:05 PM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 02/26/2016 at 02:00:17 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:5 Changed on 02/29/2016 at 09:38:21 AM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- Tester changed from Unknown to Scheer
- The favicon remains, even on a new tab.
ABB 1.3.0-qa (836)
iPhone 6 Plus - iOS 9.2.1
comment:6 Changed on 02/29/2016 at 10:30:11 AM by mario
- Milestone Adblock-Browser-for-iOS-next deleted
- Resolution set to fixed
- Status changed from reopened to closed
Removed the milestone and closed the issue. This change isn't supposed to land in 1.3.0.
comment:7 Changed on 03/02/2016 at 02:47:54 PM by mario
- Milestone set to Adblock-Browser-for-iOS-next
Rebased the current release branch to include this ticket.
comment:8 Changed on 03/03/2016 at 01:51:24 PM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- A new issue has now come of this change. When following step 6 and selecting the back option within the browser, the browser now crashes.
The HA crash report can be found here:(https://rink.hockeyapp.net/manage/apps/197999/app_versions/369/crash_reasons/113216632)
ABB 1.3.0-qa (844)
iPhonew 6 Plus - iOS 9.2.1
comment:9 Changed on 03/03/2016 at 02:27:21 PM by jand
The issue should be fixed.
comment:10 Changed on 03/07/2016 at 11:47:39 AM by jand
- Resolution set to fixed
- Status changed from reopened to closed
comment:11 Changed on 03/07/2016 at 01:09:15 PM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- The above-described issue as per my comment above still occurs.
ABB 1.3.0-qa (844)
iPhone 6 Plus - iOS 9.2.1
comment:12 Changed on 03/10/2016 at 06:36:00 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Verified working set
- No favicon is displayed for empty tabs in the tabs menu.
ABB 1.3.0-qa (851)
iPhone 6 Plus 9.2.1
https://www.pivotaltracker.com/story/show/114008531