Opened on 02/18/2016 at 04:32:55 PM
Closed on 03/18/2016 at 06:53:36 PM
Last modified on 03/18/2016 at 06:54:58 PM
#3669 closed change (fixed)
Refactor Puppet class adblockplus::log::uplink
Reported by: | matze | Assignee: | matze |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #3576 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
... which has been introduced before #3638, but can undergo some major improvements as soon as class adblockplus::host has been merged:
- Use a fully qualified rsa_public_key instead of the legacy $ssh_public_key fragment
- Use the official $fqdn
- Remove unused parameters not examined, like $role and $groups
- Fetch default values from the Adblockplus::Host instance of the same $name
In addition, future use may focus on ensure_resource() calls on-demand, instead of relying on parameter $adblockplus::hosts and function create_resources().
Attachments (0)
Change History (2)
Note: See
TracTickets for help on using
tickets.
In the context of #3825 class adblockplus::log::uplink is removed, hence this ticket here is considered obsolete.