Opened on 02/22/2016 at 07:41:57 PM

Last modified on 10/08/2019 at 05:45:42 PM

#3680 new defect

[codereview] "Invalid IPv6 URL [ValueError]" when publishing comments

Reported by: trev Assignee:
Priority: Unknown Milestone:
Module: Infrastructure Keywords:
Cc: matze Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

How to reproduce

  1. Add a comment on ​this line.
  2. Attempt to publish comments.

Observed behaviour

Error "Invalid IPv6 URL [ValueError]" shows up on ​https://codereview.adblockplus.org/29336684/publish.

Expected behaviour

No error, usual list of comments.

Background

This is a bug in django.utils.html.urlize, it attempts to highlight hgbook)}}](http://hgbook.red-bean.com as a URL and fails (urlparse.unsplit() throws the exception above). I hotfixed this on the server for now by adjusting the regular expression, Django's ​official patch however simply catches the exception. Unfortunately, Django's patch won't apply cleanly to Django 1.4 used by Rietveld.

Attachments (0)

Change History (2)

comment:1 Changed on 02/22/2016 at 07:52:58 PM by trev

Upstream issue: ​https://github.com/rietveld-codereview/rietveld/issues/541

comment:2 Changed on 04/06/2019 at 07:32:22 AM by Addu12

spam

Last edited on 10/08/2019 at 05:45:42 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.