Replace Exec['fetch_sitescripts'] with Class['sitescripts']

[matze]

Referencing Puppet resources declared within another scope is considered bad practice if the target entities are not explicitly documented to be included in the list of publicly accessible properties. Hence the multiple occurrences of require relationships referring directly to Exec['fetch_sitescripts'] are considered deprecated:

$ grep -R fetch_sitescripts *
modules/downloadserver/manifests/init.pp:      Exec['fetch_sitescripts'],
modules/notificationserver/manifests/init.pp:      Exec['fetch_sitescripts'],
modules/sitescripts/manifests/init.pp:  exec { "fetch_sitescripts":
modules/statsmaster/manifests/downloads.pp:                 Exec["fetch_sitescripts"]
modules/updateserver/manifests/init.pp:    require => [Exec['fetch_sitescripts'],
modules/updateserver/manifests/init.pp:      Exec["fetch_sitescripts"],
modules/web/manifests/server.pp:        Exec["fetch_sitescripts"],
modules/web/manifests/server.pp:      Exec['fetch_sitescripts', 'install_jsdoc'],

Those are to be replaced by references to Class['sitescripts'].

[matze]

​https://docs.puppetlabs.com/puppet/latest/reference/lang_containment.html

[abpbot]

Some commits referencing this issue have landed:

• ​https://hg.adblockplus.org/infrastructure/rev/9fe8587fa9e8
• ​https://hg.adblockplus.org/infrastructure/rev/d2661ed7ff6f
• ​https://hg.adblockplus.org/infrastructure/rev/cbfaeafb09c6
• ​https://hg.adblockplus.org/infrastructure/rev/547305284280
• ​https://hg.adblockplus.org/infrastructure/rev/c22348628b3c

[matze]

$ grep -R fetch_sitescripts *
modules/sitescripts/manifests/init.pp:  exec { "fetch_sitescripts":
modules/sitescripts/manifests/init.pp:    require => Exec["fetch_sitescripts"],