Opened on 04/22/2014 at 03:46:32 PM
Closed on 03/04/2015 at 09:54:32 PM
#370 closed defect (fixed)
element blocking is previewed even if filter URL is removed completely
| Reported by: | philll | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.8.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
Chrome, Opera, Safari
How to reproduce
- Click on the ABP icon
- Select "Block element"
- Click on any element
- Edit or remove the filter
- Click "Save"
Observed behaviour
The element that was clicked on is instantly removed from the page.
Expected behaviour
The element(s) that match the the saved filters (if any) should be removed instead.
Attachments (0)
Change History (9)
comment:2 Changed on 04/22/2014 at 04:45:19 PM by mapx
- Cc smultron45@gmail.com added
comment:3 Changed on 04/22/2014 at 04:51:14 PM by mapx
comment:4 Changed on 04/23/2014 at 07:34:30 AM by philll
- Owner set to greiner
- Status changed from new to assigned
comment:5 Changed on 04/23/2014 at 07:34:39 AM by philll
- Review URL(s) modified (diff)
- Status changed from assigned to reviewing
comment:6 Changed on 06/25/2014 at 04:16:57 PM by sebastian
- Description modified (diff)
I replaced the description in order to cover not only images and the case when the filter was edited.
comment:7 Changed on 07/15/2014 at 10:48:12 AM by philll
- Component changed from Unknown to Platform
- Platform set to Unknown
comment:8 Changed on 03/04/2015 at 10:10:14 AM by sebastian
- Owner changed from greiner to sebastian
- Review URL(s) modified (diff)
I'm taking this over now. I've uploaded a new patch, that injects CSS rules for the added element hiding filters and reuses "check collapse" functionality to determine whether the selected element should be blocked, as discussed in the other review.
Note: See
TracTickets for help on using
tickets.
there is already a patch in review:
http://codereview.adblockplus.org/5088751004942336/