Opened on 02/26/2016 at 03:35:17 PM
Closed on 03/02/2016 at 10:51:02 AM
Last modified on 10/08/2019 at 05:46:10 PM
#3706 closed change (fixed)
Upgrade Puppet patch version
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | fred, fhd | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29337797 |
||
Description
Puppet issues 21409 (fixed in 3.3.0) and 13567 (fixed in 2.7.14) affect a lot of our code since we're using more and more separation between data (from Hiera/ENC/YAML) and logic (in Puppet/Ruby). In particular they prohibit us from using Puppet namevars in any parameter set that is not hard-wired. While in some cases we are lucky not triggering the issues just yet, other cases need to get tackled with pretty dirty workarounds.
Todo
The patch-set for Puppet issue 13567 is actually a partial fix for the namevar problematic (21409 fixes custom namevars other than $name). Upgrade to Puppet 2.7.14+ in order to include that fix and to allow for continuing the Hiera/ENC integration (which is considered a prerequisite for a Puppet major version update).
Attachments (0)
Change History (7)
comment:1 Changed on 02/26/2016 at 07:29:56 PM by matze
- Cc fhd added
- Owner set to matze
comment:2 Changed on 02/26/2016 at 07:35:49 PM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 02/26/2016 at 10:51:16 PM by matze
https://hg.adblockplus.org/infrastructure/rev/d3de0841abbd
Existing hosts need to be migrated manually though (we do not manage Puppet in Puppet), which we will do in the next days.
comment:4 Changed on 03/01/2016 at 03:35:10 PM by matze
While the first patch-set works perfectly well with development images, the production one results in the following error:
The following packages have unmet dependencies:
puppet-common : Depends: facter (< 2.0) but 2.4.6-1puppetlabs1 is to be installed
Recommends: debconf-utils but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
Pinning facter seems to solve the issue:
Package: facter Pin: version 1.* Pin-Priority: 501
Another patch-set will follow soon.
comment:5 Changed on 03/02/2016 at 10:48:37 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/5dd03f0be5af
comment:6 Changed on 03/02/2016 at 10:51:02 AM by matze
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from reviewing to closed
comment:7 Changed on 05/30/2019 at 07:25:58 AM by AdamEvans
spam
Note that in development environment we're using an Ubuntu image with Puppet pre-installed, thus the setup script now produces a bunch of unfortunate warnings about over-written files during first provision.