Opened on 03/07/2016 at 01:26:49 PM
Closed on 04/21/2017 at 09:38:19 AM
Last modified on 10/08/2019 at 05:46:21 PM
#3742 closed change (invalid)
Make behavior of checkboxes on options page consistent
Reported by: | greiner | Assignee: | |
---|---|---|---|
Priority: | P2 | Milestone: | |
Module: | User-Interface | Keywords: | |
Cc: | athornburgh, saroyanm, sebastian, wspee | Blocked By: | |
Blocking: | #2355 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by greiner)
Background
It is non-obvious what effects checking or unchecking a checkbox has on the item. Therefore we should simplify the logic and make it more consistent.
Checkbox behavior (current/expected)
Language filter lists
- current: adds/removes list item
- expected: adds/removes filter list
Recommended filter lists
- current: enables/disables list item
- expected: adds/removes filter list
Custom filter lists
- current: adds/removes list item
- expected: adds/removes filter list
Acceptable Ads
- current: enables/disables list item
- expected: adds/removes filter list
Filter lists in Advanced tab
- current: enables/disables list item
- expected: enables/disables filter list
Preferences in Tweaks section
- current: enables/disables list item
- expected: enables/disables preference
What to change
- Checkboxes for removable list items (language filter lists, custom filter lists) should enable or disable the item
- Checkboxes for non-removable list items (recommended filter lists, Acceptable Ads, filter lists in Advanced tab) should add or remove the item
Attachments (0)
Change History (6)
comment:2 Changed on 05/19/2016 at 08:11:23 AM by saroyanm
comment:3 Changed on 05/19/2016 at 08:19:04 AM by sebastian
Seem like separate issues to me.
comment:4 Changed on 04/20/2017 at 06:31:18 PM by saroyanm
- Cc wspee added
@Winsley before closing this ticket make sense to be sure that this request is being reflected in the specifications.
comment:5 Changed on 04/21/2017 at 09:38:19 AM by wspee
- Resolution set to invalid
- Status changed from new to closed
comment:6 Changed on 08/08/2019 at 12:00:48 PM by annajohnsn
spam
Last edited on 10/08/2019 at 05:46:21 PM
by kzar
Note: See
TracTickets for help on using
tickets.
Should this be covered in #3741 ?