Opened on 03/09/2016 at 12:44:29 PM
Closed on 07/05/2017 at 08:03:49 AM
Last modified on 07/05/2017 at 08:05:54 AM
#3766 closed defect (fixed)
Restore default ABP bookmarks
| Reported by: | rjeschke | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
Mozilla changed the way mobile bookmarks work, i.e. removed those and is now using the desktop ones. This change currently breaks the tests for building Fennec. A temporary solution to get the build working again is to disable the tests by adding ac_add_options --disable-tests to your mozconfig.
Previously bookmarks were defined via a locale specific bookmarks.inc file in the mobile folder. See here. The corresponding string definitions were to be found here (Those strings are currently commented out in branch abb_fennec_44_0_2_merge).
With the latest merge, Mozilla has removed the mobile specific bookmarks.inc file.
We need a way to get the bookmarks and their strings working again.
Furthermore we need to remove the predefined Mozilla bookmarks.
Hints for Testers
The project should build without the need of adding ac_add_options --disable-tests to the mozconfig file
After installing the app, check if these bookmarks are added by default:
About your browser (about:)
Acceptable Ads (https://acceptableads.org)
Adblock Plus (https://adblockplus.org)
Beta community (https://adblockplus.org/redirect?link=adblock_browser_android_beta_community)
After installing the app, check if these bookmarks are not added:
Firefox: About your browser (about:firefox)
Firefox: Customize with add-ons (https://addons.mozilla.org/android/)
Firefox: Support (https://support.mozilla.org/products/mobile)
Learn the Web: Mozilla Webmaker (https://webmaker.org/)
Firefox Help and Support for restricted profiles on Android tablets (https://support.mozilla.org/kb/controlledaccess)
Attachments (0)
Change History (10)
comment:2 Changed on 05/10/2016 at 09:08:59 AM by diegocarloslima
- Owner set to diegocarloslima
comment:4 Changed on 05/10/2016 at 03:52:01 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 10/19/2016 at 02:32:36 PM by abpbot
comment:7 Changed on 10/19/2016 at 02:33:44 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 06/19/2017 at 11:13:29 AM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- Tester changed from Unknown to Scheer
Is there any more updates on the change here. Did we use this method in the end, to get the build to function or did we revert since then? could we have some more information to the issue and maybe add some hints for testers?
Thanks
comment:10 Changed on 07/05/2017 at 08:03:49 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Verified working set
- After installing the app, the following bookmarks are added by default:
- About your browser (about:)
- Acceptable Ads (https://acceptableads.org)
- Adblock Plus (https://adblockplus.org)
- Beta community (https://adblockplus.org/redirect?link=adblock_browser_android_beta_community)
- After installing the app, the following bookmarks are not added:
- Firefox: About your browser (about:firefox)
- Firefox: Customize with add-ons (https://addons.mozilla.org/android/)
- Firefox: Support (https://support.mozilla.org/products/mobile)
- Learn the Web: Mozilla Webmaker (https://webmaker.org/)
- Firefox Help and Support for restricted profiles on Android tablets (https://support.mozilla.org/kb/controlledaccess)
adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
A commit referencing this issue has landed:
Issue 3766 - Restore default ABP bookmarks