Opened on 03/12/2016 at 01:31:11 PM

Closed on 03/16/2016 at 05:36:24 PM

#3787 closed change (fixed)

Let Trac restart automatically after a crash

Reported by: matze Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29338168

Description

... by integrating Puppet type customservice::supervisor with type trac::instance.

Attachments (0)

Change History (4)

comment:1 Changed on 03/12/2016 at 01:44:55 PM by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/12/2016 at 02:27:40 PM by matze

I've altered the first patch-set, after further tests reviled some limitations in the supervisor's script logic:

[keep_alive_services]
spawn-fcgi = /var/run/500-tracd_issues_spawn-fcgi.pid
spawn-fcgi = /var/run/500-tracd_orders_spawn-fcgi.pid

Every trac::instance is started using the spawn-fcgi init script, which the Python code assumes the settings.ini key to correspond to. Now since equal keys override each other in the order of appearance, only one value is recognized anyway. And those values are expected to correspond to the PID files.

Hence the new version does not directly integrate with trac::instance, but the declaring manifest, and only considers the primary instance.

comment:3 Changed on 03/16/2016 at 05:30:15 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/infrastructure/rev/95515f9411e7

comment:4 Changed on 03/16/2016 at 05:36:24 PM by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from matze.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.