Opened on 04/25/2014 at 09:40:21 AM

Closed on 04/28/2014 at 11:37:23 AM

#381 closed change (fixed)

Update to nginx 1.6

Reported by: trev Assignee: christian
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: fhd Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5716525453410304/

Description

Background

Our servers currently use nginx 1.4 which is the legacy branch now - current stable and supported release is nginx 1.6. The only change that seems relevant for us is the support for SPDY 3.1. Also, sub_filter_last_modified directive should be relevant for the main server.

What to change

Update to nginx 1.6, verify that it doesn't create any issues in the test environments (nginx 1.2 to 1.4 update actually produced issues with the way we listened to IPv6 addresses).

Attachments (0)

Change History (8)

comment:1 Changed on 04/25/2014 at 10:47:28 AM by fhd

I'm pretty sure 1.4 is going to get security updates, from Ubuntu if not from upstream. I agree that we shouldn't wait too long, but this doesn't seem like a P2 change.

comment:2 Changed on 04/25/2014 at 11:03:30 AM by trev

We don't install nginx from Ubuntu.

comment:3 Changed on 04/25/2014 at 12:54:04 PM by trev

  • Priority changed from P2 to P3

comment:4 Changed on 04/28/2014 at 08:02:39 AM by christian

  • Owner set to christian
  • Status changed from new to assigned

I make the change and put it up to review

http://codereview.adblockplus.org/5716525453410304/

comment:5 Changed on 04/28/2014 at 08:44:26 AM by christian

  • Review URL(s) modified (diff)

comment:6 Changed on 04/28/2014 at 09:07:03 AM by trev

  • Status changed from assigned to reviewing

comment:7 Changed on 04/28/2014 at 10:02:55 AM by trev

I've updated to nginx 1.6 on the unmanaged servers, no issues it seems.

comment:8 Changed on 04/28/2014 at 11:37:23 AM by christian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from christian.
 
Note: See TracTickets for help on using tickets.