Opened on 03/17/2016 at 08:42:40 PM
Closed on 03/17/2016 at 08:50:36 PM
Last modified on 05/25/2016 at 11:44:39 AM
#3828 closed change (fixed)
Ignore simulated clicks on abp:subscribe links
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Websites can simulate a click on abp:subscribe links. While the user still needs to confirm the subscription to be added, this can be irritating in particular if websites repeatedly do that.
What to change
Ignore simulated clicks on abp:subscribe links based on Event.isTrusted (where supported).
Attachments (0)
Change History (4)
comment:1 Changed on 03/17/2016 at 08:44:04 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/17/2016 at 08:49:51 PM by abpbot
comment:3 Changed on 03/17/2016 at 08:50:36 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/25/2016 at 11:44:39 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Tested via attempting to click it via the console and via a script added to a locally served copy of the testpages (and its subscribe link).
ABP 1.11.0.1606
Chrome 45, 50 / Windows 7
Chrome 45, 50 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/4d845c1d2115