Wrong image shows up briefly for Adblock Plus icon

[trev]

This isn't an issue I can reproduce but it is fairly obvious what is causing it. Here the original report from the blog:

The only problem I have is a “blinking” of the UI when Firefox starts : It seems like a line of icons appears and disappears at the top of the browser. Nothing really serious but it’s a bit annoying, and is clearly related to adblock+ as everything works fine when it’s disabled.

Background

Adblock Plus icon uses toolbar-1 class to ensure correct styling. Among the default styles for this class is the following:

list-style-image: url("chrome://browser/skin/Toolbar.png");

We override it in our own styles but it seems that under some conditions these style load after the button is inserted in the document - meaning that for a brief time chrome://browser/skin/Toolbar.png is displayed as the image here.

What to change

We can add style="list-style-image: none;" attribute to the icon, this will make sure that the default style cannot apply. Our styles can then override that attribute using !important flag.

[arthur]

I can reproduce this. Let me know if you need anything.

[trev]

Only confirming once this is fixed - I'm fairly certain that the solution I outlined will do.

[trev]

Should be fixed: ​https://hg.adblockplus.org/adblockplus/rev/540b36aa0dc7

Arthur, there will be a new development build in five minutes, could you verify that this issue is really fixed?

[arthur]

It is still happening for me with 2.6.0.3812.

Apparently this bug doesn't seem to affect Firefox 29 with the new Australis design but the old one below 29.

[trev]

Backed out the change: ​https://hg.adblockplus.org/adblockplus/rev/2aafe9a3a965

Unfortunately, I still cannot reproduce this, not even with Firefox 28.

[trev]

I was able to reproduce this on Windows with Firefox 28 by slowing down startup (added several filter subscriptions and made sure two fairly heavy tabs load on startup). The fix above indeed doesn't work for some reason, the style attribute is simply ignored. If I change attributes of the element then all the sudden the styles apply.

[trev]

In the end the only solution appears to be removing the toolbarbutton-1 class in Firefox. Not having it in Thunderbird apparently makes our icon look better as well. SeaMonkey is the only place where we actually need it, so I made sure it is added there (had to restore handling of defaultToolbarPosition.addClass which apparently got lost in the Australis update).

[trev]

I'm closing these since we no longer support pre-Australis versions of Firefox.