Opened on 03/19/2016 at 08:14:51 PM
Closed on 03/23/2016 at 01:36:02 PM
Last modified on 05/26/2016 at 01:00:48 PM
#3841 closed change (fixed)
Remove workaround stripping [style] selectors on certain websites
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
In 2011, a bug in Chrome was found that broke some functionality in Google Mail (apparently Yahoo Mail was effected as well), when an extension injects any CSS rules using selectors that target the style attribute.
As a workaround Adblock Plus stripped all element hiding filters using such selectors on mail.google.com, www.google.com and mail.yahoo.com.
However, I cannot reproduce that issue anymore. And given that the bug is 5 years old chances that the same code in Chrome and/or Google Mail that caused the issue back then still exists is rather low anyway. If a similar bug still exists, it most likely effects a different set of websites.
What to change
Remove the workaround stripping selectors that target the style attribute on some websites.
Attachments (0)
Change History (7)
comment:1 Changed on 03/19/2016 at 08:15:04 PM by sebastian
- Summary changed from Remove workaround stripping [style] selectors on certain websites. to Remove workaround stripping [style] selectors on certain websites
comment:2 Changed on 03/19/2016 at 08:16:50 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/23/2016 at 01:33:09 PM by abpbot
comment:5 Changed on 03/23/2016 at 01:36:02 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/26/2016 at 12:35:38 PM by Ross
I'm unsure how I should test this? Check if advert filtering works in Google mail?
comment:7 Changed on 05/26/2016 at 01:00:48 PM by sebastian
See the reproduction steps in the Chrome bug, but instead step 1. add the custom filter ##foobar > div[style] in Adblock Plus. Make sure that in particular on old Chrome versions Gmail doesn't break.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/15dabaeee975