Opened on 03/20/2016 at 03:45:38 PM

Closed on 03/23/2016 at 01:36:25 PM

#3843 closed change (fixed)

Move page load logic to their respective modules

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29338771

Description

Background

There is a ext.pages.onLoading listener defined in background.js that resets the composer (aka "Block element") and shows notifications for the page's (new) URL. This logic, however, rather belongs in to the respective modules.

What to change

Remove the ext.pages.onLoading listener from background.js and move that logic to the filterComposer and notigficationHelper modules.

Attachments (0)

Change History (3)

comment:1 Changed on 03/20/2016 at 03:46:34 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/23/2016 at 01:33:16 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/adblockpluschrome/rev/258e00ad016a

comment:3 Changed on 03/23/2016 at 01:36:25 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.