Opened on 03/22/2016 at 10:27:28 AM
Closed on 04/19/2016 at 12:14:22 PM
Last modified on 04/20/2016 at 09:13:52 AM
#3853 closed change (fixed)
Use new messaging API for the first-run page
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.7.3-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | #3499 | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
The messaging code used by the first-run page currently duplicates much of what we implemented in #3499.
What to change
Use the new messaging API for communicating with the first-run page, the ext APIs should be implemented on top of it.
Attachments (0)
Change History (5)
comment:2 Changed on 03/22/2016 at 01:56:48 PM by trev
- Status changed from new to reviewing
comment:3 Changed on 04/19/2016 at 12:13:49 PM by abpbot
comment:4 Changed on 04/19/2016 at 12:14:22 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 04/20/2016 at 09:13:52 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
First run page still behaves as expected after changes.
ABP 2.7.2.4163
Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/67a6569e54e1