Opened on 03/24/2016 at 02:44:29 PM
Closed on 03/24/2016 at 03:41:10 PM
Last modified on 05/09/2016 at 07:45:06 AM
#3872 closed defect (fixed)
"Block element" does not finish when popup window is closed
| Reported by: | kzar | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Adblock Plus for Chrome as of https://hg.adblockplus.org/adblockpluschrome/rev/47cff5dab9c2
How to reproduce
- Click to block an element
- When the popup window opens close the window (with your window manager, not by clicking the "Cancel" button).
Observed behaviour
Element blocking is still in progress, the element is still highlighted red and the option to cancel is still given by the extension popup.
Expected behaviour
Element blocking should stop, like it did before.
Attachments (0)
Change History (6)
comment:1 Changed on 03/24/2016 at 02:53:29 PM by sebastian
- Owner set to sebastian
- Priority changed from Unknown to P1
- Ready set
comment:2 Changed on 03/24/2016 at 02:54:12 PM by sebastian
- Summary changed from Element blocking does not finish when popup window is closed to "Block element" does not finish when popup window is closed
comment:3 Changed on 03/24/2016 at 03:11:34 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
This regression was introduced by f2c48546e442. Through all the rebasing, the name of the message to be sent when the popup is closed, got somehow reverted to it's former name.
comment:4 Changed on 03/24/2016 at 03:40:32 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/75435efcb391
comment:5 Changed on 03/24/2016 at 03:41:10 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/09/2016 at 07:45:06 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
The Block element state now ends correctly if the popup is closed via window manager.
ABP 1.11.0.1597
Chrome 32 / 50 / Windows 10
Opera 23 / 36 / Windows 10
Chrome 32 / 50 / OS X 10.11
Opera 31 / 36 / OS X 10.11
Safari 6 / 7 / 9.1 / OS X 10.8/10.9/10.11
Chrome 50 / Ubuntu 14.04
Opera 36 / Ubuntu 14.04
Reproduced with the current development build. Doesn't happen with Adblock Plus 1.11.