Opened on 03/30/2016 at 11:20:04 AM
Closed on 04/11/2016 at 01:41:27 PM
Last modified on 04/13/2016 at 03:42:19 AM
#3877 closed defect (fixed)
Already open options page not updated
| Reported by: | Ross | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Environment
Reproduced in:
ABP 1.11.0.1590 / Safari 9 / OS X 10.11 (also effects Chrome and Opera)
Could not reproduce in:
ABP 1.11.0.1558 / Safari 9 / OS X 10.11
How to reproduce
- Install extension and open ABP options page.
- Visit adblockplus.org in a new tab.
- Select [ABP Icon] > [Enabled on this page] to disable.
- Switch back to already open ABP options page.
- Observe whitelist has not been updated with action from Step 3.
Observed behaviour
As of 045c2a14adaa, the already opened options page is not updated with the whitelist entry created by the user actions in Step 3. Refreshing/opening the options page then shows the state correctly. An exception is shown in the options page as the non existing onFilterChange function is called.
This regression was caused by https://hg.adblockplus.org/adblockpluschrome/rev/045c2a14adaa , it looks like we forgot to change calls to the onFilterChange function in two places.
Expected behaviour
The already open options page to stay in sync with current user selections/actions as it used to.
Attachments (0)
Change History (13)
comment:1 Changed on 03/30/2016 at 11:32:45 AM by kzar
- Cc sebastian kzar added
- Component changed from Unknown to Platform
- Milestone Adblock-Plus-for-Chrome-Opera-Safari-next deleted
- Priority changed from P3 to Unknown
comment:2 Changed on 03/30/2016 at 11:39:59 AM by kzar
- Owner set to kzar
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 03/30/2016 at 12:11:18 PM by kzar
comment:7 Changed on 03/30/2016 at 12:37:10 PM by sebastian
- Description modified (diff)
- Platform changed from Safari to Unknown / Cross platform
comment:8 Changed on 03/30/2016 at 12:39:42 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/b98aedabc3ac
comment:9 Changed on 03/30/2016 at 12:41:13 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 04/07/2016 at 11:47:53 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 1.11.0.1592
Safari 6.0 / OS X 10.8
Safari 7.1.8 / OS X 10.9.5
Safari 8.0.6 / OS X 10.10.3
Safari 9.1 / OS X 10.11
comment:11 Changed on 04/11/2016 at 12:45:56 PM by Ross
- Resolution fixed deleted
- Status changed from closed to reopened
This actually still occurs. Added filters (via block element in popup) do not get displayed correctly in the options page. This seems to occur more often when the options page is opened right after install, but have also seen it occur when the options page is opened later.
Most of the time it works as expected.
ABP 1.11.0.1593
Safari 6.0 / OS X 10.8
Safari 7.1.8 / OS X 10.9.5
Safari 8.0.6 / OS X 10.10.3
comment:12 Changed on 04/11/2016 at 12:58:05 PM by kzar
This sounds more like a new regression caused by the changes in #3870. Could you confirm if the problem is reproducible with 1.11.0.1592?
comment:13 Changed on 04/11/2016 at 01:41:27 PM by Ross
- Resolution set to fixed
- Status changed from reopened to closed
You're right. This does not occur in 1592. Reported as #3915
ABP 1.11.0.1592
Safari 6.0 / OS X 10.8
Safari 7.1.8 / OS X 10.9.5
Safari 8.0.6 / OS X 10.10.3
Can reproduce as described at HEAD but not at 1.11. Looking into it now.