Opened on 04/01/2016 at 03:38:58 PM

Closed on 04/15/2016 at 04:54:57 PM

#3885 closed change (fixed)

Disable the checkbox to toggle the Acceptable Ads list on the new options page

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, athornburgh Blocked By:
Blocking: #2372 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29339287

Description (last modified by sebastian)

Background

With the old options page, as well as with all of our other products, we don't let the user disable the Acceptable Ads list, but only remove it. That way we can rely on the number of requests downloading exceptionrules.txt, in order to estimate how many people use Acceptable Currently, with the new options page, however it would be possible to just disable the Acceptable Ads list in Advanced tab.

What to change

Disable the checkbox to toggle the Acceptable Ads list in the Advanced tab.

Attachments (0)

Change History (6)

comment:1 Changed on 04/01/2016 at 03:39:56 PM by sebastian

  • Description modified (diff)
  • Summary changed from Don't allow disabling, but removing, the Acceptable Ads list on the new options page to Disable the checkbox to toggle the Acceptable Ads list on the new options page

comment:2 Changed on 04/01/2016 at 03:41:12 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/01/2016 at 04:56:15 PM by greiner

  • Cc athornburgh added
  • Priority changed from Unknown to P3
  • Ready set

This should be good enough for a temporary fix.

We should, however, keep investigating ways on how to treat the Acceptable Ads filter list in the Advanced tab to fulfill all of our requirements:

  • The Advanced tab should contain all installed filter lists.
  • It should be clear that the filter list can be removed.
  • The user should not be able to enable/disable the filter list (although we could expose ​a preference for that as we do in Firefox).

@athornburgh Any ideas in that regard?

comment:4 Changed on 04/01/2016 at 05:01:10 PM by greiner

  • Blocking 2372 added

comment:5 Changed on 04/15/2016 at 04:53:58 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/adblockplusui/rev/315d4d5afa2e

comment:6 Changed on 04/15/2016 at 04:54:57 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.