Opened on 04/08/2016 at 05:13:46 PM

Closed on 04/08/2016 at 05:36:33 PM

#3908 closed defect (fixed)

Broken website links on option page if subscription homepage isn't given

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339616

Description

Observed behaviour

For subscriptions that don't specify a homepage, the new options page is still showing a website link in the context menu on the Advanced tab. However, clicking the link, obviously doesn't have any effect.

Expected behaviour

The website link should be hidden for subscriptions that don't specify a homepage.

Attachments (0)

Change History (4)

comment:1 Changed on 04/08/2016 at 05:15:20 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/08/2016 at 05:28:46 PM by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 04/08/2016 at 05:36:07 PM by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/67941a4397e5

comment:4 Changed on 04/08/2016 at 05:36:33 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.