Opened on 04/27/2014 at 08:20:30 PM
Last modified on 01/22/2016 at 11:04:29 AM
#392 new change
Malware Domains updates don't make it to the repository
Reported by: | trev | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | matze, fred | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
A few months ago we've set up a dedicated filter master server that no longer resides on the same host as the Mercurial server. The filter master checks for Malware Domains updates regularly, these are supposed to go into https://hg.adblockplus.org/malwaredomains/ repository. However, they now land in the local copy of the Malware Domains repository on the filter master and aren't uploaded back to our Mercurial server. This doesn't affect the generated files because the filter master uses that same local copy for subscription generation - but this is still a rather unfortunate setup.
What to change
Running Malware Domains list updates on the Mercurial server isn't a great solution - we should separate tasks rather than putting everything on the same server again. The alternative is having the update script clone the remote repository and push to it rather than using the local copy (local copy would be kept in sync with the remote repository automatically). This means that the filter master will need SSH access to the repository, a few script/configuration changes will be necessary as well.
I think we should reconsider the priority here since we are constantly facing our potential breakages that we can't monitor easily without having the diff from the repo. A recent example is #3521