Opened on 04/14/2016 at 04:07:32 PM
Closed on 04/29/2016 at 03:34:31 PM
Last modified on 04/29/2016 at 03:41:47 PM
#3931 closed defect (fixed)
Crash on filter list request/delivery
| Reported by: | rjeschke | Assignee: | rjeschke |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.0.2 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | fhd, vickyyu | Blocked By: | #3953 |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by rjeschke)
There's a preference mismatch that is probably caused by using different Contexts for retrieving the SharedPreference object. This mismatch is causing a crash of the ContentProvider when SBrowser is trying to fetch the filters.
A two step solution is needed here:
- Fix the underlying issue that's causing this problem, i.e. the differing Context issue
- Fix the error in the preferences after it appeared, i.e. users might have already a corrupted preferences state, this must be checked and fixed (fixed via clean sweeping the preferences state)
Attachments (0)
Change History (12)
comment:1 Changed on 04/19/2016 at 10:19:39 AM by vickyyu
- Cc vickyyu added
comment:2 Changed on 04/25/2016 at 02:15:14 PM by rjeschke
- Blocked By 3953 added
comment:5 Changed on 04/25/2016 at 03:46:31 PM by rjeschke
comment:6 Changed on 04/26/2016 at 09:35:11 AM by rjeschke
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 04/26/2016 at 09:36:24 AM by rjeschke
- Priority changed from Unknown to P1
comment:9 Changed on 04/27/2016 at 09:54:44 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplussbrowser/rev/699391e34c95
comment:10 Changed on 04/27/2016 at 11:34:12 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- No crashes have been observed when the user pushes for new filters.
ABP Sbrowser adblockplussbrowser-1.0.2-20160426113120-release
Sbrowser 4.0
Samsung Galaxy S5
Android Galaxy S7
Android 5.0
Android 6.0
comment:11 Changed on 04/29/2016 at 03:34:31 PM by rjeschke
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 04/29/2016 at 03:41:47 PM by mario
- Milestone set to Adblock-Plus-for-Samsung-Browser-1.0.2
Note: See
TracTickets for help on using
tickets.
As the signing stuff is finally resolved, I will hopefully have a solution to this whole issue ready during tomorrow ... although I did not test the signed APK yet, I'm pretty confident that there shouldn't be any more issues on the signing front.
Fixing the rest is trivial and shouldn't take longer than a day.