Opened on 04/15/2016 at 01:28:43 PM
Closed on 11/10/2017 at 11:17:30 AM
#3941 closed change (rejected)
Set exact window size of Firefox window.
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Extensions-for-Adblock-Plus | Keywords: | abpcrawler |
| Cc: | trev, TobiasHilleke, tschuster | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sergz)
Background
acceptable ads has a criterion regarding the size of ad, in particular what portion of visible space it occupies. To stay consistent in terms of the size of screenshots among runs of abpcrawler it would be good to set a window size according to the screen size mentioned in acceptable ads.
I guess, we may neglect the fact that at least fonts are differently rendered on different machines or after updates, the important thing is to distinguish between e.g. 3840x2160 and 1368x768 configurations.
What to change
Add CLI parameter for window size and call window.resizeTo(windowWidth, windowHeight); at the beginning of run function in crawler.js.
Attachments (0)
Change History (6)
comment:1 Changed on 04/15/2016 at 01:41:00 PM by trev
comment:2 Changed on 04/15/2016 at 01:50:14 PM by sergz
- Description modified (diff)
I also thought about it, however decided to don't mention it in this issue so far because if we decide to test it on different resolutions then according to https://adblockplus.org/acceptable-ads we should rather consider a possibility to test on or at least better emulate different platforms (mobile, tablet). Anyway, I have added it into the description.
comment:3 Changed on 04/15/2016 at 02:00:49 PM by trev
The crawler is a general-purpose tool and not limited to Acceptable Ads, which is why this kind of settings generally should not be hardcoded. So not "ideally" but rather required.
comment:5 Changed on 04/15/2016 at 03:24:09 PM by trev
- Ready set
comment:6 Changed on 11/10/2017 at 11:17:30 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.
I'd prefer to have this configurable rather than hardcoded. We can have a command line parameter defaulting to 1368x768. And we should start thinking about proper configuration files...