Opened on 03/11/2014 at 11:33:51 AM

Closed on 03/13/2014 at 08:56:25 AM

Last modified on 03/19/2014 at 04:23:40 PM

#40 closed defect (fixed)

[trac] whitespaces in attachment names lead to broken attachment URLs

Reported by: philll Assignee: trev
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: no Confidential: no
Tester: Verified working: yes
Review URL(s):

​http://codereview.adblockplus.org/5719138018263040/

Description

How to reproduce

  1. Open an existing trac issue at ​https://issues.adblockplus.org
  2. Expand the "Attachments" section
  3. Click the "Attach File button"
  4. Click the "Choose File" button
  5. Select a file with a whitespace in its name for uploading
  6. Click the Add Attachment" button
  7. Click the file's name

Observed behaviour

The following note is displayed:

Error: Invalid Attachment
Attachment 'ticket:1: white%20space.2.png' does not exist.

Expected behaviour

The file should be displayed and/or offered for download

Attachments (0)

Change History (10)

comment:1 Changed on 03/11/2014 at 12:09:02 PM by trev

Implemented a proper way to set up PATH_INFO variable: ​http://codereview.adblockplus.org/5719138018263040

comment:2 Changed on 03/11/2014 at 12:49:39 PM by trev

  • Status changed from new to accepted

comment:3 Changed on 03/11/2014 at 12:49:53 PM by trev

  • Owner set to trev
  • Status changed from accepted to assigned

comment:4 Changed on 03/11/2014 at 12:50:07 PM by trev

  • Status changed from assigned to accepted

comment:5 Changed on 03/12/2014 at 11:25:23 AM by trev

  • Status changed from accepted to assigned

comment:6 Changed on 03/12/2014 at 11:25:31 AM by trev

  • Status changed from assigned to reviewing

comment:7 Changed on 03/13/2014 at 07:54:19 AM by trev

  • Priority changed from Unknown to P2

comment:8 Changed on 03/13/2014 at 08:56:25 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/infrastructure/rev/2c87b4162260

comment:9 Changed on 03/18/2014 at 05:28:41 PM by trev

  • in_progress set to 0
  • Ready unset
  • Review URL(s) modified (diff)

comment:10 Changed on 03/19/2014 at 04:23:40 PM by philll

  • Verified working set

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.