Opened on 04/27/2016 at 06:24:32 PM

Closed on 04/28/2016 at 12:10:50 PM

#4001 closed change (fixed)

Update dependency on adblockpluscore to revision d576e2dac412

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340904/

Description

Background

This update will import #3998 and allow simplifying logic in Firefox.

What to change

No need to emulate ext.backgroundPage.sendMessage() in Firefox, a proper callback can be passed to CSSPropertyFilters constructor now.

What to test

CSS property filters functionality should still work.

Attachments (0)

Change History (3)

comment:1 Changed on 04/27/2016 at 06:29:17 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/28/2016 at 12:10:09 PM by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/19b8454c9e2f

comment:3 Changed on 04/28/2016 at 12:10:50 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.