Opened on 04/28/2016 at 10:13:27 AM
Closed on 04/28/2016 at 04:06:08 PM
Last modified on 06/23/2016 at 10:11:32 AM
#4003 closed defect (fixed)
Change "Adblock" to "Adblock Browser" in the Safari app extension
| Reported by: | mario | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-1.4.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Environment
Any iOS version
Any ABB version
How to reproduce
- Open Safari
- Open the Safari app extension by tapping the share-logo at the bottom of the app
- Locate the Adblock Browser logo in the app extension
- Optional: If the Adblock Browser logo is not present, locate the "... More" option, tap it and enable Adblock Browser.
Observed behaviour
The label of the Adblock Browser logo reads "Adblock" as shown in this screenshot.
Expected behaviour
The label of the Adblock Browser logo should read "Adblock Browser"
Attachments (1)
Change History (9)
Changed on 04/28/2016 at 10:13:43 AM by mario
comment:2 Changed on 04/28/2016 at 10:14:35 AM by mario
- Ready set
comment:3 Changed on 04/28/2016 at 03:50:52 PM by pavelz
comment:4 Changed on 04/28/2016 at 04:06:08 PM by pavelz
- Resolution set to fixed
- Status changed from new to closed
Mind that now it's technically fixed for english only. For other localizations, Crowdin translation roundtrip must be passed - which takes place on public release schedule. Even if the app name is the same as in english, as is the case for most other languages.
comment:5 Changed on 04/28/2016 at 04:06:08 PM by pavelz
- Resolution set to fixed
- Status changed from new to closed
Mind that now it's technically fixed for english only. For other localizations, Crowdin translation roundtrip must be passed - which takes place on public release schedule. Even if the app name is the same as in english, as is the case for most other languages.
comment:6 Changed on 05/19/2016 at 07:42:49 AM by pavelz
- Milestone set to Adblock-Browser-for-iOS-next
comment:7 Changed on 05/30/2016 at 06:56:50 AM by scheer
I can confirm that for English this now states 'Adblock Browser'. But I will leave this issue open for localisation to confirm.
ABB 1.4.0 (988)
iPhone 6s Plus
iOS 9.3.1
comment:8 Changed on 06/23/2016 at 10:11:32 AM by Shikitita
- Verified working set
https://www.pivotaltracker.com/story/show/118573765