Opened on 04/29/2014 at 12:37:41 PM
Closed on 09/17/2014 at 08:05:04 PM
#402 closed change (fixed)
Use a redirector script for downloads, not a direct link
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Infrastructure | Keywords: | 2014q3 |
| Cc: | jobp@adblockplus.org, greiner, annlee@adblockplus.org | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5747446760079360/ |
||
Description
Background
Currently the sitescripts.extensions.bin.updateDownloadLinks script generates various download links. These links are being included into Anwiki pages using an Anwiki plugin. As the pages themselves only update once per hour this introduces unnecessary delays on new releases - in addition to complicating the switch from Anwiki to our CMS.
What to change
Don't use direct links in the pages, use a fixed link like https://adblockplus.org/currentrelease/adblockplus.xpi that will redirect to the actual download link.
Given #401 it might also make sense to separate generation of download links from generation of update manifests.
Attachments (0)
Change History (9)
comment:1 Changed on 05/22/2014 at 01:31:56 PM by philll
- Keywords 2014q3 added
comment:2 Changed on 05/28/2014 at 01:01:30 PM by jobp
- Cc jobp@adblockplus.org added
comment:3 Changed on 09/08/2014 at 09:50:44 AM by greiner
- Cc greiner added
- Platform set to Unknown
comment:4 Changed on 09/09/2014 at 09:56:59 PM by trev
- Owner set to trev
comment:5 Changed on 09/09/2014 at 10:02:35 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 09/16/2014 at 02:21:21 PM by annlee@adblockplus.org
- Cc annlee@adblockplus.org added
comment:8 Changed on 09/16/2014 at 03:33:15 PM by trev
- Priority changed from P3 to P2
comment:9 Changed on 09/17/2014 at 08:05:04 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Fixed:
https://hg.adblockplus.org/sitescripts/rev/2fd18171451e
https://hg.adblockplus.org/infrastructure/rev/2d58c5b2c763
https://hg.adblockplus.org/infrastructure/rev/5692b8de0248
https://hg.adblockplus.org/www/rev/cc60eb395b02
https://hg.adblockplus.org/www/rev/26db74df8c68
https://hg.adblockplus.org/www/rev/ded556038aa5
https://hg.adblockplus.org/www/rev/9c3577449775
https://hg.adblockplus.org/www/rev/56352ec63e86