Opened on 05/11/2016 at 08:42:04 AM
Closed on 05/16/2016 at 03:36:33 PM
Last modified on 06/01/2016 at 12:19:40 PM
#4035 closed defect (fixed)
A page gets closed if it was opened as popup and contains blocked resources
| Reported by: | scheer | Assignee: | pavelz |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-1.4.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by pavelz)
When the user attempts to open certain sites from news.google.com, the page starts opening as a new tab as expected, but gets closed immediately. Some of these pages are zeit.de and computerwoche.de.
Environment
ABB 1.3.2
iPhone 6 Plus S
iOS 9.3.1
How to reproduce
- Visit news.google.com
- Open an article from zeit.de
Observed behaviour
The opened window is immediately closed and the user is brought back to news.google.de.
Expected behaviour
The news article window from zeit.de should remain open.
Attachments (1)
Change History (8)
Changed on 05/11/2016 at 08:42:12 AM by scheer
comment:1 Changed on 05/11/2016 at 08:52:14 AM by mario
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 05/13/2016 at 08:18:02 AM by pavelz
- Owner set to pavelz
comment:3 Changed on 05/13/2016 at 08:22:26 AM by pavelz
- Cc mario added
- Description modified (diff)
- Summary changed from chrome.tabs.remove closes zeit.de when opened from news.google.com to A page gets closed if it was opened as popup and contains blocked resources
@mario reworded issue summary, please review
comment:4 Changed on 05/13/2016 at 08:25:45 AM by pavelz
comment:5 Changed on 05/16/2016 at 03:36:33 PM by pavelz
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed on 05/17/2016 at 07:19:00 AM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:7 Changed on 06/01/2016 at 12:19:40 PM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
I have now opened varying pages from news.google.com with no adverse effects. Opening previous culprits such as zeit.de now open with no issues at all.
ABB 1.4.0 (996)
iPhone 6s Plus
iOS 9.3.1
Note: See
TracTickets for help on using
tickets.
The bug is triggered by the new ABP popup handling code. When popup creation is catched in webNavigation.onCreatedNavigationTarget, extension creates an additional temporary listener to webRequest.onBeforeRequest, restricted to resourceType=main_frame. Due to a bug in Kitt core, this additional listener is called for ALL requests from the popup, not only main_frame. If there is a resource in the popup which has to be blocked, this new listener considers it main_frame and closes the whole popup as blocked. In case of zeit.de, the blocked content is either from doubleclick.net or de.com. But it would happen equally for any other page with blockable content, if it happens to get opened as popup.