Opened on 04/29/2014 at 02:36:39 PM
Last modified on 02/12/2015 at 06:41:42 PM
#404 reviewing change
Validate Internet Explorer version in the installer
| Reported by: | trev | Assignee: | eric@adblockplus.org |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | installer |
| Cc: | eric@adblockplus.org | Blocked By: | |
| Blocking: | #1090 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Currently we don't check the Internet Explorer version that is installed. Given that we no longer want to support Internet Explorer 6 and 7 this needs to change
What to change
The installed should show an error message recommending the user to update.
Attachments (0)
Change History (8)
comment:2 in reply to: ↑ 1 Changed on 05/01/2014 at 06:18:36 PM by trev
Replying to eric@…:
Parallel installation of multiple versions of IE isn't common, but is possible.
This is an explicitly unsupported setup - and everybody doing that knows that it is unsupported (already because there are numerous issues). So I don't think verifying IE version in the plugin is really a priority. Doing that in the installer is however.
comment:3 Changed on 07/09/2014 at 12:36:01 PM by philll
- Platform set to Internet Explorer
comment:4 Changed on 07/20/2014 at 07:29:54 PM by eric@adblockplus.org
- Blocking 1090 added
comment:5 Changed on 08/14/2014 at 01:48:23 PM by fhd
- Keywords installer added
comment:6 Changed on 01/09/2015 at 08:09:05 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:7 Changed on 02/12/2015 at 06:41:34 PM by eric@adblockplus.org
- Owner set to eric@adblockplus.org
comment:8 Changed on 02/12/2015 at 06:41:42 PM by eric@adblockplus.org
- Status changed from new to reviewing
Note: See
TracTickets for help on using
tickets.
In addition to the installer, we should probably also add a check in the plugin itself. Parallel installation of multiple versions of IE isn't common, but is possible. The scenario is that the install detects a later version of IE on the system but the plugin runs under a non-supported version. Even if rare, we likely don't want our plugin crashing the browser.
We get different information from the plugin than is available in the installer. With the plugin, we can locate the executable we're running under. This need not be the same executable as we find in the ordinary place on the file system. There may be an IE API call to determine the version, but I don't know it offhand.