Opened on 05/12/2016 at 01:11:35 PM

Last modified on 09/26/2019 at 10:16:12 AM

#4040 reopened change

Adjustments in redirects used by ABB for Android: Privacy, FAQ and support

Reported by: diegocarloslima Assignee: matze
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: matze Blocked By:
Blocking: #3220 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29347268

Description (last modified by diegocarloslima)

Background

In order to provide proper localization to some URLs used by Adblock Browser for Android, some adjustments in redirect URLs are required

What to change

Redirect: privacy
Changes: Needs to be created and have support for lang parameter.
E.g. https://adblockplus.org/redirect?link=privacy&lang=de should redirect to https://adblockplus.org/de/privacy

Redirect: adblock_browser_android_faq
Changes: Needs to be created and have support for lang parameter.
E.g. https://adblockplus.org/redirect?link=adblock_browser_android_faq&lang=de should redirect to https://adblockbrowser.org/de/android-support/faq

Redirect: adblock_browser_android_support
Changes: Add support for lang parameter
E.g. https://adblockplus.org/redirect?link=adblock_browser_android_support&lang=de should redirect to https://adblockbrowser.org/de/android-support/

Attachments (0)

Change History (11)

comment:1 Changed on 05/12/2016 at 01:13:56 PM by diegocarloslima

  • Blocking 3001 added

comment:2 Changed on 06/16/2016 at 01:31:10 PM by fhd

  • Cc matze added
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed on 06/22/2016 at 12:35:00 AM by diegocarloslima

  • Blocking 3220 added

comment:4 Changed on 06/22/2016 at 08:51:15 PM by diegocarloslima

  • Description modified (diff)
  • Summary changed from Adblock Browser Android FAQ redirect URL is broken to Adjustments in redirects used by ABB for Android: Privacy, FAQ and support

comment:5 Changed on 06/22/2016 at 10:09:55 PM by diegocarloslima

  • Type changed from defect to change

comment:6 Changed on 06/27/2016 at 08:06:39 PM by diegocarloslima

  • Blocking 3001 removed

comment:7 Changed on 07/04/2016 at 12:31:20 PM by matze

  • Owner set to matze

comment:8 Changed on 07/04/2016 at 01:41:29 PM by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed on 09/19/2016 at 01:02:40 PM by abpbot

comment:10 Changed on 09/19/2016 at 01:08:09 PM by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed on 07/04/2017 at 08:09:08 PM by diegocarloslima

  • Resolution fixed deleted
  • Status changed from closed to reopened

The ABB FAQ and support URLs are producing error 404 if the locale provided isn't supported (e.g. https://adblockplus.org/redirect?link=adblock_browser_android_faq&lang=zh-CN and https://adblockplus.org/redirect?link=adblock_browser_android_support&lang=cs )
The default behavior for this scenario should be to redirect to the default English page.

Add Comment

Modify Ticket

Change Properties
Action
as reopened .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from matze.
Next status will be 'reviewing'.
 
Note: See TracTickets for help on using tickets.