Opened on 05/19/2016 at 12:04:47 PM
Closed on 05/19/2016 at 12:51:46 PM
Last modified on 05/24/2016 at 10:25:25 AM
#4052 closed defect (fixed)
Cannot add subscriptions with Chrome 30
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, Ross, scheer | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
Chrome Version 30.0.1599.66
Adblock Plus development build 1.11.0.1604
How to reproduce
- Open the options page
- Attempt to add a new filter list subscription
Observed behaviour
Nothing happens, the subscription is not added. This is shown in the options page console:
Uncaught Error: Invocation of form runtime.sendMessage(object, undefined, null) doesn't match definition runtime.sendMessage(optional string extensionId, any message, optional function responseCallback) schemaUtils:113 normalizeArgumentsAndValidate schemaUtils:113 (anonymous function) binding:307 (anonymous function) options.js:59 addSubscriptionClicked options.js:376 f.event.dispatch jquery-1.7.1.min.js:3 h.handle.i jquery-1.7.1.min.js:3
Expected behaviour
The subscription to be added, with no exception in the console.
Notes
This is being caused when ext.backgroundPage.sendMessage is called with a callback of undefined. It works correctly when the callback is omitted instead.
Hints for testers
Ensure that you can successfully use the options page from Chrome 30. For example try adding a subscription, make sure it is really added. Check the JavaScript console for the options page for exceptions.
Attachments (0)
Change History (8)
comment:1 Changed on 05/19/2016 at 12:09:50 PM by sebastian
- Priority changed from Unknown to P1
- Ready set
comment:3 Changed on 05/19/2016 at 12:44:19 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 05/19/2016 at 12:49:52 PM by abpbot
comment:5 Changed on 05/19/2016 at 12:51:46 PM by kzar
- Cc Ross scheer added
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/24/2016 at 07:13:49 AM by Ross
This is fixed for adding subscriptions from the options page and first-run page.
However adding subscriptions from abp:subscribe links doesn't work at all (nothing happens) in Chrome 30. Subscribe links work fine in later Chrome (36, 37 so far).
ABP 1.11.0.1606
Chrome 30 / Windows 7
comment:7 Changed on 05/24/2016 at 08:00:04 AM by kzar
adding subscriptions from abp:subscribe links doesn't work at all (nothing happens) in Chrome 30
That's something else but still needs fixing, mind filing an issue?
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/7da0c7d6f601