Opened on 05/20/2016 at 11:10:43 AM
Closed on 05/20/2016 at 01:58:39 PM
Last modified on 05/26/2016 at 01:12:58 PM
#4054 closed defect (fixed)
Element hiding rules continue to be matched after being removed
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | sebastian, trev | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
adblockpluschrome after b7884247c8ed
How to reproduce
- Enable EasyList and run this code in the console:
var ElemHide = require("elemHide").ElemHide;
ElemHide.getSelectorsForDomain("www.extremetech.com");
- Disable EasyList and run the same code again.
Observed behaviour
The results are the same, an array of around 17,000 selectors.
Expected behaviour
The second time a much shorter/empty array should be returned.
Notes
When making the changes for #235 we forgot to remove filters from the filtersByDomain lookup again.
Attachments (0)
Change History (8)
comment:1 Changed on 05/20/2016 at 11:36:30 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/20/2016 at 12:15:48 PM by trev
- Component changed from Platform to Core
comment:3 Changed on 05/20/2016 at 01:44:33 PM by abpbot
comment:4 Changed on 05/20/2016 at 01:58:39 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/26/2016 at 01:12:58 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Opera 36 / Ubuntu 14.04
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluscore/rev/b791dfaa66c6