Opened on 05/20/2016 at 03:12:32 PM
Closed on 05/25/2016 at 11:37:11 AM
Last modified on 06/27/2016 at 02:32:10 PM
#4057 closed change (fixed)
Further improve ElemHide.getSelectorsByDomain() performance
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | sebastian, trev | Blocked By: | #4055, #4067 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Following the work in #235 to improve the performance of ElemHide.getSelectorsByDomain() we want to go further. With a proof of concept already performing > 3x faster than our existing implementation there's clearly room for improvement.
What to change
Further improve on the proof of concept we already have, simplifying it where is possible without a performance hit.
Attachments (0)
Change History (5)
comment:1 Changed on 05/20/2016 at 03:12:56 PM by kzar
- Status changed from new to reviewing
comment:2 Changed on 05/24/2016 at 10:50:44 AM by trev
- Blocked By 4067 added
comment:3 Changed on 05/25/2016 at 11:22:54 AM by abpbot
comment:4 Changed on 05/25/2016 at 11:37:11 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 06/27/2016 at 02:32:10 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Element hiding seems to be working as expected (including FF hit statistics) except in Firefox 38-40, which is open as #4198.
ABP 1.12.0.1622
Chrome 30 / 40 / 50 / Windows 7
Opera 19 / 36 / Windows 7
Safari 7 / 9 / / OS X 10.9 / OS X 10.11
ABP 2.7.3.4184-beta
Firefox 41-45 / Windows 7
A commit referencing this issue has landed:
Issue 4057 - Speed up ElemHide.getSelectorsForDomain