Opened on 05/31/2016 at 09:43:45 AM
Closed on 05/31/2016 at 03:07:12 PM
#4088 closed change (fixed)
JSHydra-generated module scopes shouldn't be called immediately
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | sebastian, kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
JSHydra generates an anonymous function as the scope for each module. This anonymous function is currently called immediately.
What to change
In order to generate module scopes lazily when they are require'd for the first time, this anonymous function should no longer be called.
Integration notes
In order to integrate these changes, the implementation of require() has to be changed like in #4090. In addition, JSHydra rewriting parameters have to be adjusted in order to specify the modules to be loaded automatically (in #4090 this is done in manifest.common).
Attachments (0)
Change History (4)
comment:1 Changed on 05/31/2016 at 11:36:33 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/31/2016 at 03:01:44 PM by abpbot
comment:3 Changed on 05/31/2016 at 03:03:53 PM by abpbot
A commit referencing this issue has landed:
Issue 4088 - Update dependency on JSHydra to revision bb6fb9d5c9bc
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4088 - JSHydra-generated module scopes shouldn't be called immediately