Opened on 05/31/2016 at 10:08:23 AM

Closed on 05/31/2016 at 10:38:12 AM

#4092 closed change (fixed)

Adapt unit tests for changes to InvalidFilter.reason

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Extensions-for-Adblock-Plus Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29345397/

Description

Background

InvalidFilter.reason changed to return a string ID rather than the actual error message.

What to change

Adapt unit tests to expect string IDs for this field.

Attachments (0)

Change History (3)

comment:1 Changed on 05/31/2016 at 10:15:27 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/31/2016 at 10:37:41 AM by abpbot

A commit referencing this issue has landed:
​Issue 4092 - Adapt unit tests for changes to InvalidFilter.reason

comment:3 Changed on 05/31/2016 at 10:38:12 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.