Opened on 06/01/2016 at 01:04:12 PM

Closed on 06/03/2016 at 01:03:05 PM

#4097 closed change (fixed)

Make JSHydra use SpiderMonkey location from an environment variable if available

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: #4098 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345502/

Description

Background

We want to make our build server fetch buildtools repository (and jshydra) for every build. Currently, this will make it fetch SpiderMonkey for every build as well.

What to change

Make JSHydra consider SPIDERMONKEY_BINARY environment variable and use it as JS shell if present.

Attachments (0)

Change History (6)

comment:1 Changed on 06/01/2016 at 01:09:37 PM by trev

  • Blocking 4098 added

comment:2 Changed on 06/01/2016 at 01:14:22 PM by trev

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 06/01/2016 at 01:17:16 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 06/02/2016 at 06:37:06 PM by abpbot

comment:6 Changed on 06/03/2016 at 01:03:05 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.