Opened on 06/01/2016 at 02:26:00 PM

Closed on 06/03/2016 at 01:03:44 PM

#4099 closed change (fixed)

Don't enforce Gecko build IDs to be numerical

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #4098 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29345505/

Description

Background

Right now, our command-line interface for development builds (as opposed to internal APIs) makes sure that build IDs passed in with the -b flag are numerical. This prevents Gecko development builds where we currently have build IDs like 1234-beta.

What to change

Drop requirement for build IDs to be numerical (at least for Gecko, other platforms aren't as flexible when it comes to version numbers).

Attachments (0)

Change History (3)

comment:1 Changed on 06/01/2016 at 02:32:10 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 06/02/2016 at 06:37:36 PM by abpbot

A commit referencing this issue has landed:
​Issue 4099 - Don't enforce Gecko build IDs to be numerical

comment:3 Changed on 06/03/2016 at 01:03:44 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.