Opened on 04/30/2014 at 03:48:44 PM
Closed on 05/01/2014 at 09:08:51 AM
Last modified on 05/02/2014 at 08:40:05 AM
#411 closed defect (incomplete)
Adblock Plus doesn't hide a specific element on cinema-city.co.il
| Reported by: | arthur | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | arthur, smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Firefox 29
Windows 8.1 Pro x64 Update 1
Adblock Plus 2.6.0.3804
Element Hding Helper 1.3.0.463
How to reproduce
- Go to http://www.cinema-city.co.il/
- Select this banner on the left via Element Hiding Helper until this filter is suggested like in the screenshots:
cinema-city.co.il##.layerItem.34.ItemClass-10-2-34
Observed behaviour
The banner isn't removed in the composer preview and also not if you add the filter to ABP.
Expected behaviour
The banner should be hidden in the composer preview and also if you add it to ABP. If you select another hiding filter with the "style" tag, it works as expected.
Attachments (2)
Change History (8)
Changed on 04/30/2014 at 03:48:59 PM by arthur
Changed on 04/30/2014 at 03:50:44 PM by arthur
comment:1 Changed on 04/30/2014 at 04:35:16 PM by mapx
- Cc smultron45@gmail.com added
comment:2 Changed on 05/01/2014 at 02:05:15 AM by barbaz
comment:3 Changed on 05/01/2014 at 09:08:51 AM by arthur
- Resolution set to invalid
- Status changed from new to closed
Thanks!
comment:4 Changed on 05/01/2014 at 08:36:12 PM by mapx
if the filter
cinema-city.co.il##.layerItem.34.ItemClass-10-2-34
is suggested by EHH, it's something wrong with the same EHH
comment:5 Changed on 05/02/2014 at 01:50:55 AM by barbaz
A more EHH-suitable filter suggestion than what I wrote above would be
cinema-city.co.il##.layerItem[class~="34"].ItemClass-10-2-34
(Apparently, any id or whitespace-separated fragment of a class that starts with a number cannot be used with the #id or .class CSS selectors.)
comment:6 Changed on 05/02/2014 at 08:40:05 AM by arthur
@mapx
EHH simply suggests a filter according to what's in the source of a page.
This isn't an Adblock Plus issue. What you're seeing is caused by the fact that
.34
is not a valid CSS selector. The following filter will work:
cinema-city.co.il##.layerItem.ItemClass-10-2-34[class*=" 34"]