Opened on 06/03/2016 at 03:11:38 PM
Closed on 07/17/2018 at 09:54:22 AM
#4116 closed change (fixed)
Make infile and outfile parameters of flrender script from python-abp optional
| Reported by: | kvas | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | matze, sebastian, atudor | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
flrender, the script that renders filter lists, requires two parameters: input file and output file. In some cases, however, it's more convenient to give the input on stdin and receive the output from stdout instead. The two parameters should be made non-mandatory with default output being stdout and default input being stdin to allow this way of using the script.
What to change
- Make the parameters non-mandatory with a default value of '-'.
- If the output is '-', write to stdout instead of opening a file.
- Override get method in TopSource in abp/filters/sources.py to read stdin if the file name is '-'.
- Update the documentation accordingly.
Attachments (0)
Change History (4)
comment:1 Changed on 07/04/2018 at 09:04:33 AM by kvas
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 07/09/2018 at 09:48:20 AM by atudor
- Cc atudor added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 07/17/2018 at 09:53:09 AM by abpbot
comment:4 Changed on 07/17/2018 at 09:54:22 AM by atudor
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4116 - Make infile and outfile parameters of flrender script from python-abp optional