Opened on 06/07/2016 at 04:00:05 PM
Closed on 06/08/2016 at 12:24:16 PM
Last modified on 06/30/2019 at 11:28:41 PM
#4129 closed change (fixed)
Reuse EventEmitter class in messaging module
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-2.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Core has an events module providing EventEmitter class now, the API is very similar to the Port class in messaging module.
What to change
Encapsulate an event emitter for the Port class and delegate managing of event listeners to it.
Attachments (0)
Change History (3)
comment:1 Changed on 06/07/2016 at 04:01:08 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 06/08/2016 at 12:23:45 PM by abpbot
comment:3 Changed on 06/08/2016 at 12:24:16 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4129 - Reuse EventEmitter class in messaging module