Opened on 06/07/2016 at 04:06:57 PM

Closed on 06/13/2016 at 11:12:25 PM

Last modified on 10/08/2019 at 05:48:21 PM

#4131 closed change (fixed)

Simplify UI initialization logic

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29345630/

Description

Background

The UI initialization logic is currently rather complicated, it has to wait for three different events to happen.

What to change

Use promises to join the three events required for UI initialization. Also, use new FilterNotifier API.

Attachments (0)

Change History (5)

comment:1 Changed on 06/07/2016 at 04:23:13 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 06/13/2016 at 11:12:25 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/7cf793d35ab7

comment:3 Changed on 05/15/2019 at 09:04:11 AM by Archie Radcliffe

spam

Last edited on 10/08/2019 at 05:48:15 PM by kzar

comment:4 Changed on 05/18/2019 at 07:25:28 AM by Ora Kessler

spam

Last edited on 10/08/2019 at 05:48:18 PM by kzar

comment:5 Changed on 08/15/2019 at 09:41:44 AM by johnsullen

spam

Last edited on 10/08/2019 at 05:48:21 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.