Opened on 06/27/2016 at 02:29:31 PM
Closed on 06/30/2016 at 03:34:42 PM
Last modified on 08/22/2016 at 10:25:28 AM
#4199 closed defect (fixed)
Enabling Safari content blocking causes ABP to lose track of options tab
| Reported by: | Ross | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.12.2-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian | Blocked By: | |
| Blocking: | Platform: | Safari | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Environment
ABP 1.12
Safari 9 / OS X 10.11
How to reproduce
- Install ABP 1.12 and enable Safari Content Blocking.
- Select [ABP Icon] > [Options]. Options page appears in a new tab.
- Navigate to a website in the options page tab (I used http://www.arstechnica.com).
- Select [ABP Icon] > [Options].
Observed behaviour
Nothing happens when the [Options] button is pushed. You have to close the tab opened in step 2 for the button to work.
Expected behaviour
The [Options] button should continue to work.
Notes
This behaviour is present in 1.12 and more recent code, but only when the Safari Content Blocking feature is enabled.
Attachments (0)
Change History (5)
comment:1 Changed on 06/27/2016 at 02:57:38 PM by kzar
- Cc sebastian added
- Component changed from Unknown to Platform
- Description modified (diff)
- Owner set to kzar
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 06/27/2016 at 03:12:30 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/30/2016 at 03:32:46 PM by abpbot
A commit referencing this issue has landed:
Issue 4199 - Track Safari tabs properly in Content Blocking mode
comment:4 Changed on 06/30/2016 at 03:34:42 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 08/22/2016 at 10:25:28 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- When selecting [ABP Icon] > [Options] after loading a new page in the already opened options page, the new options page loaded correctly.
ABP 1.12.1.1644
Safari 9 / OS X 10.11
Note: See
TracTickets for help on using
tickets.
Can reproduce as described with 1.12 and the latest code scheduled for the 1.12.1 release. Like you say it seems to only happen when using the experimental content blocking feature.
As this bug exists in the existing version and is relatively minor I think we should go ahead with the 1.12.1 release tomorrow anyway. Ultimately though that's up to Sebastian.
Either way I'm investigating to understand what's causing this bug now.